New config param to define point estimates to calculate when running a CatEstimator stage
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SHARED_PARAMS` that will be used by subclasses of `CatEstimator`.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 97.53% 97.54%
=======================================
Files 28 28
Lines 1585 1586 +1
=======================================
+ Hits 1546 1547 +1
Misses 39 39
☔ View full report in Codecov by Sentry. |
aimalz
approved these changes
Aug 3, 2023
|
it would make sense as a next step to add a function to the base class to actually use the new parameter. |
This was referenced Aug 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
It is not yet settled whether the default should be no calculations or all calculations done on behalf of the user. However, this PR is still mostly valid regardless of the decision.
Introduce a new config parameters,
calculated_point_estimates, inSHARED_PARAMSthat will be used by subclasses ofCatEstimator.