Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

46 parallelize var inf #77

Merged
merged 4 commits into from
Nov 20, 2023
Merged

46 parallelize var inf #77

merged 4 commits into from
Nov 20, 2023

Conversation

joselotl
Copy link
Contributor

Problem & Solution Description (including issue #)

This commit parallelizes point_est_hist, and var_inf. Also I rewrote naive_stack to share functions with point_est_hist.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@joselotl joselotl linked an issue Nov 16, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (263b2a6) 96.96% compared to head (382217e) 97.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   96.96%   97.17%   +0.21%     
==========================================
  Files          32       32              
  Lines        1714     1736      +22     
==========================================
+ Hits         1662     1687      +25     
+ Misses         52       49       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josue

@joselotl joselotl merged commit 499c244 into main Nov 20, 2023
6 checks passed
@joselotl joselotl deleted the 46-parallelize-var_inf branch July 16, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelize var_inf
2 participants