Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation docstrings #78

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Creation docstrings #78

merged 3 commits into from
Nov 21, 2023

Conversation

OliviaLynn
Copy link
Member

@OliviaLynn OliviaLynn commented Nov 17, 2023

Problem & Solution Description (including issue #)

For LSSTDESC/rail#22 (creation docstrings only)

Made this branch before seeing Drew's dedicated branch for the issue, sorry Drew

Code Quality

  • My code follows the code style of this project
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format

@OliviaLynn OliviaLynn mentioned this pull request Nov 17, 2023
11 tasks
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (263b2a6) 96.96% compared to head (8cfc16f) 97.17%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   96.96%   97.17%   +0.21%     
==========================================
  Files          32       32              
  Lines        1714     1736      +22     
==========================================
+ Hits         1662     1687      +25     
+ Misses         52       49       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you so much for cleaning this up :)

@OliviaLynn OliviaLynn merged commit 87c9b42 into main Nov 21, 2023
6 checks passed
@OliviaLynn OliviaLynn deleted the issue/22/docstrings-creation branch November 21, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants