Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed model error and changed code to set run without symlink #37

Merged
merged 6 commits into from
May 14, 2024

Conversation

raphaelshirley
Copy link
Collaborator

@raphaelshirley raphaelshirley commented May 14, 2024

Closes #36

We should perhaps set the link to the run directory in a more robust way. currently I get it from the default work directory and go up a level to runs. We also might wnat to make it overwritable in the estimator so that the folder can be moved between systems

Using the symlinked $cache/lephare/work directory creates the possibility of two informers using it simultaneously and intereferring with the default location during local runs. rail_lepahre should use completely independent work directories using the informer name.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

We should perhaps set the link to the run directory in a more robust way. currently I get it from the default work directory and go up a level to runs.
We also might wnat to make it overwritable in the estimator so that the folder can be moved between systems
@raphaelshirley raphaelshirley changed the title Fixed model error and changed code to set run without lin Fixed model error and changed code to set run without symlink May 14, 2024
Raphael Shirley added 2 commits May 14, 2024 19:47
we dont know why it is there in rail_bpz but the code runs without it
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 91.93%. Comparing base (e5c47db) to head (52ded5c).
Report is 23 commits behind head on main.

Files Patch % Lines
src/rail/estimation/algos/lephare.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #37      +/-   ##
===========================================
- Coverage   100.00%   91.93%   -8.07%     
===========================================
  Files            1        2       +1     
  Lines            8      124     +116     
===========================================
+ Hits             8      114     +106     
- Misses           0       10      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@raphaelshirley raphaelshirley merged commit b0c0c8e into main May 14, 2024
4 of 6 checks passed
@raphaelshirley raphaelshirley deleted the issue/36/create-unlinked-run-directory branch May 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create unlinked run directory
2 participants