Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two small fixes to gaia_object.py #106

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

JoanneBogart
Copy link
Collaborator

Fix two things affecting gaia objects:

  1. Interface for load_collection changed a while back to include a new optional argument, exposure, but GaiaCollection.load_collection was not updated at the time. It's done in this PR
  2. A while ago a config value id_prefix in the section about Gaia stars. If it was omitted from the config and someone wanted to include Gaia stars in their search, skyCatalogs would crash. The fix here is to use a default value if the key is omitted from the config.

Copy link
Collaborator

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoanneBogart JoanneBogart merged commit 25e6c66 into main Jun 12, 2024
1 check passed
@JoanneBogart JoanneBogart deleted the u/jrbogart/gaia_exposure_patch branch June 12, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants