Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG failing when running on matplotlib 3.8 #82

Closed
maikia opened this issue Sep 22, 2023 · 1 comment · Fixed by #85
Closed

BUG failing when running on matplotlib 3.8 #82

maikia opened this issue Sep 22, 2023 · 1 comment · Fixed by #85
Labels
Type: Bug

Comments

@maikia
Copy link

maikia commented Sep 22, 2023

Thanks for your great work,

I tried running your code with the newest version of matplotlib (3.8) but unfortunately it fails.

Error from matplotlib:

*** AttributeError: 'YTick' object has no attribute 'label'

originating at forsetplot/graph_utils.py line: pad = max( T.label.get_window_extent(renderer=fig.canvas.get_renderer()).width for T in yax.majorTicks )

Downgrading to matplotlib 3.7.3 solves the issue
@Tian-hao
Copy link

Matplotlib 3.8.0 updated the Tick object.

Changing T.label to T.label1 should solve the problem.

LSYS added a commit that referenced this issue Dec 14, 2023
@LSYS
Troubleshooting mpl Tick label (fixes #82)
de6b9e7
@LSYS LSYS mentioned this issue Dec 14, 2023
Merged
@LSYS LSYS closed this as completed in #85 Dec 14, 2023
LSYS added a commit that referenced this issue Dec 14, 2023
@LSYS
Merge pull request #85 from LSYS/patch
55c76f1 
* Fixes #82 
* Fixes #74
@LSYS LSYS added the Type: Bug label Dec 14, 2023
LSYS added a commit that referenced this issue Dec 14, 2023
@LSYS
Fixes #82
705766b
LSYS added a commit that referenced this issue Dec 16, 2023
@LSYS
Fix compatibility with newer mpl versions (#82)
09af3d4
LSYS added a commit that referenced this issue Dec 16, 2023
@LSYS
Add docstring & test for mdraw_yticklabels (#88, #89) (#91)
794f491 
* Troubleshooting workflow error (#87)

Pytest showing nan==nan as error for py3.9 and py3.10.

* Add branch to workflow (#88)

* Testing make_multimodel_tableheaders (#88)

* Add test_make_multimodel_tableheaders (#88)

* Pleasing linters (#88)

* Add docstring & test for  (#88, #89)

* Fix compatibility with newer mpl versions (#82)

* Pleasing linters

* Pleasing linters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch LSYS/forestplot
3 participants
@maikia @Tian-hao @LSYS