Skip to content

Commit

Permalink
Remove python 2 exceptions
Browse files Browse the repository at this point in the history
  • Loading branch information
Janneke Janssen committed Oct 3, 2018
1 parent 325da15 commit 207463f
Show file tree
Hide file tree
Showing 10 changed files with 8 additions and 27 deletions.
2 changes: 0 additions & 2 deletions tests/test_wagtailformblocks.py
Expand Up @@ -4,8 +4,6 @@
Tests for `wagtailformblocks` module.
"""
from __future__ import unicode_literals

import json

import pytest
Expand Down
5 changes: 2 additions & 3 deletions wagtailformblocks/blocks.py
@@ -1,5 +1,3 @@
from __future__ import absolute_import, unicode_literals

from django import forms
from django.urls import reverse

Expand Down Expand Up @@ -44,7 +42,8 @@ def get_context(self, value, parent_context=None):
if not parent_context:
context = super(WagtailFormBlock, self).get_context(value)
else:
context = super(WagtailFormBlock, self).get_context(value, parent_context)
context = super(WagtailFormBlock, self).get_context(
value, parent_context)

form = value['form']

Expand Down
1 change: 0 additions & 1 deletion wagtailformblocks/forms.py
@@ -1,5 +1,4 @@
from captcha.fields import ReCaptchaField
from django.conf import settings
from wagtail.contrib.forms.forms import FormBuilder as OrigFormBuilder

from wagtailformblocks.utils.conf import (
Expand Down
2 changes: 0 additions & 2 deletions wagtailformblocks/migrations/0001_initial.py
@@ -1,7 +1,5 @@
# -*- coding: utf-8 -*-
# Generated by Django 1.10 on 2016-08-23 09:55
from __future__ import unicode_literals

from django.db import migrations, models
import django.db.models.deletion
import modelcluster.fields
Expand Down
2 changes: 0 additions & 2 deletions wagtailformblocks/migrations/0002_baseform_add_recaptcha.py
@@ -1,7 +1,5 @@
# -*- coding: utf-8 -*-
# Generated by Django 1.10.2 on 2016-10-28 12:21
from __future__ import unicode_literals

from django.db import migrations, models


Expand Down
9 changes: 2 additions & 7 deletions wagtailformblocks/models.py
@@ -1,11 +1,7 @@
from __future__ import absolute_import, unicode_literals

import json

from django.core.serializers.json import DjangoJSONEncoder
from django.db import models
from django.utils import six
from django.utils.encoding import python_2_unicode_compatible
from django.utils.translation import ugettext_lazy as _
from model_utils.managers import InheritanceManager
from modelcluster.fields import ParentalKey
Expand All @@ -19,7 +15,6 @@
from .utils.conf import recaptcha_enabled


@python_2_unicode_compatible
class FormSubmission(models.Model):
"""Data for a Form submission."""

Expand All @@ -42,7 +37,6 @@ class FormField(AbstractFormField):
form = ParentalKey('BaseForm', related_name='form_fields')


@python_2_unicode_compatible
class BaseForm(ClusterableModel):
name = models.CharField(max_length=255)
store_submission = models.BooleanField(
Expand Down Expand Up @@ -92,6 +86,7 @@ def process_form_submission(self, form):
if recaptcha_enabled():
BaseForm.panels.insert(2, FieldPanel('add_recaptcha'))


class EmailForm(BaseForm):
"""
A Form Page that sends email. Pages implementing a form to be send
Expand Down Expand Up @@ -134,7 +129,7 @@ def send_form_mail(self, form):
if name == 'recaptcha' or not data:
continue
content.append(
field.label + ': ' + six.text_type(data))
field.label + ': ' + str(data))

send_mail(
self.subject, '\n'.join(content), addresses, self.from_address)
2 changes: 0 additions & 2 deletions wagtailformblocks/urls.py
@@ -1,5 +1,3 @@
from __future__ import unicode_literals

from django.conf.urls import url

from .views import FormProcessView
Expand Down
2 changes: 0 additions & 2 deletions wagtailformblocks/utils/conf.py
@@ -1,5 +1,3 @@
from __future__ import absolute_import, unicode_literals

from django.conf import settings
from django.utils.translation import ugettext_lazy as _

Expand Down
9 changes: 3 additions & 6 deletions wagtailformblocks/views.py
@@ -1,7 +1,4 @@
from __future__ import absolute_import, unicode_literals

from django.http import JsonResponse
from django.utils import six
from django.views.generic import View

from .models import BaseForm
Expand All @@ -17,7 +14,7 @@ def post(self, request, pk):
formdef = BaseForm.objects.get_subclass(id=pk)
except BaseForm.DoesNotExist:
err = {
'message': six.text_type(get_formblocks_setting('ERROR_MSG')), # NOQA
'message': str(get_formblocks_setting('ERROR_MSG')), # NOQA
'detail': 'Could not find WagtailForm with id {}'.format(pk)
}
return JsonResponse(err, status=400)
Expand All @@ -28,13 +25,13 @@ def post(self, request, pk):
formdef.process_form_submission(form)
else:
err = {
'message': six.text_type(get_formblocks_setting('ERROR_MSG')), # NOQA
'message': str(get_formblocks_setting('ERROR_MSG')), # NOQA
'detail': form.errors
}
return JsonResponse(err, status=400)

resp = {
'message': formdef.success_message or six.text_type(
'message': formdef.success_message or str(
get_formblocks_setting('SUCCESS_MSG')
)
}
Expand Down
1 change: 1 addition & 0 deletions wagtailformblocks/wagtail_hooks.py
Expand Up @@ -41,6 +41,7 @@ class SubmissionAdmin(ModelAdmin):
list_display = ('form_data', 'form', 'submit_time')
list_filter = ('form', )


form_admins.append(SubmissionAdmin)


Expand Down

0 comments on commit 207463f

Please sign in to comment.