Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update output format #118

Merged
merged 6 commits into from
Nov 11, 2020
Merged

Update output format #118

merged 6 commits into from
Nov 11, 2020

Conversation

Redmar-van-den-Berg
Copy link
Collaborator

Checklist

  • Pull request details were added to HISTORY.rst

The current output is quite hard to read when you have many tests, since the full output for each test is written to a single line. This branch changes that to a more structured format, which is easier to read.

Before

plugins: workflow-1.5.0.dev0
collecting ... 
collected 20 items                                                                                                                                                                                                                                      
start 'test-cromwell' with command 'cromwell --version
' in '/tmp/pytest_workflow_79ovc__9/test-cromwell'. stdout: '/tmp/pytest_workflow_79ovc__9/test-cromwell/log.out'. stderr: '/tmp/pytest_workflow_79ovc__9/test-cromwell/log.err'.
'test-cromwell' done.
start 'test-womtool' with command 'womtool --version
' in '/tmp/pytest_workflow_79ovc__9/test-womtool'. stdout: '/tmp/pytest_workflow_79ovc__9/test-womtool/log.out'. stderr: '/tmp/pytest_workflow_79ovc__9/test-womtool/log.err'.
'test-womtool' done.
start 'validate-workflow-wdl' with command 'womtool validate PacBio-variantcalling.wdl
' in '/tmp/pytest_workflow_79ovc__9/validate-workflow-wdl'. stdout: '/tmp/pytest_workflow_79ovc__9/validate-workflow-wdl/log.out'. stderr: '/tmp/pytest_workflow_79ovc__9/validate-workflow-wdl/log.err'.
'validate-workflow-wdl' done.
start 'validate-workflow-settings' with command 'womtool validate --inputs tests/data/config/variant_calling.json PacBio-variantcalling.wdl
' in '/tmp/pytest_workflow_79ovc__9/validate-workflow-settings'. stdout: '/tmp/pytest_workflow_79ovc__9/validate-workflow-settings/log.out'. stderr: '/tmp/pytest_workflow_79ovc__9/validate-workflow-settings/log.err'.
'validate-workflow-settings' done.

After

plugins: workflow-1.5.0.dev0
collecting ... 
collected 20 items                                                                                                                                                                                                                                      

test-cromwell:
	command:   cromwell --version
	directory: /tmp/pytest_workflow_3xgo95y7/test-cromwell
	stdout:    /tmp/pytest_workflow_3xgo95y7/test-cromwell/log.out
	stderr:    /tmp/pytest_workflow_3xgo95y7/test-cromwell/log.err
'test-cromwell' done.

test-womtool:
	command:   womtool --version
	directory: /tmp/pytest_workflow_3xgo95y7/test-womtool
	stdout:    /tmp/pytest_workflow_3xgo95y7/test-womtool/log.out
	stderr:    /tmp/pytest_workflow_3xgo95y7/test-womtool/log.err
'test-womtool' done.

validate-workflow-wdl:
	command:   womtool validate PacBio-variantcalling.wdl
	directory: /tmp/pytest_workflow_3xgo95y7/validate-workflow-wdl
	stdout:    /tmp/pytest_workflow_3xgo95y7/validate-workflow-wdl/log.out
	stderr:    /tmp/pytest_workflow_3xgo95y7/validate-workflow-wdl/log.err
'validate-workflow-wdl' done.

validate-workflow-settings:
	command:   womtool validate --inputs tests/data/config/variant_calling.json PacBio-variantcalling.wdl
	directory: /tmp/pytest_workflow_3xgo95y7/validate-workflow-settings
	stdout:    /tmp/pytest_workflow_3xgo95y7/validate-workflow-settings/log.out
	stderr:    /tmp/pytest_workflow_3xgo95y7/validate-workflow-settings/log.err
'validate-workflow-settings' done.

@rhpvorderman
Copy link
Member

Looks good. I always found this one of the "room for improvement" things!

@rhpvorderman
Copy link
Member

It will need some changes to the tests though, as the output is also tested.

@rhpvorderman rhpvorderman merged commit aa8be4b into develop Nov 11, 2020
@rhpvorderman rhpvorderman deleted the format-output branch November 11, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants