Skip content tests when file does not exist. #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flow into enormous_wall_text
rhpvorderman
requested changes
Nov 11, 2022
HISTORY.rst
Outdated
| @@ -9,6 +9,7 @@ Changelog | |||
|
|
|||
| version 1.7.0-dev | |||
| --------------------------- | |||
| + Add skip for tests searching non existing file | |||
There was a problem hiding this comment.
Can you word this more clearly? Is "a skip" a thing?
src/pytest_workflow/content_tests.py
Outdated
| @@ -243,8 +243,9 @@ def runtest(self): | |||
| this makes content checking much faster on big files (NGS > 1 GB files) | |||
| were we are looking for multiple words (variants / sequences). """ | |||
| # Wait for thread to complete. | |||
| if self.parent.file_not_found: | |||
| pytest.skip(f"'{self.content_name}' not found so cant be searched") | |||
There was a problem hiding this comment.
cant -> cannot. https://www.grammarly.com/blog/cannot-or-can-not/
tests/test_skip_tests.py
Outdated
| def test_skips(pytester): | ||
| pytester.makefile(".yml", test=SKIP_TESTS) | ||
| result = pytester.runpytest("-v").stdout.str() | ||
| assert "4 failed, 3 passed, 3 skipped" in result |
There was a problem hiding this comment.
What if pytest outputs "3 passed, 3 skipped, 4 failed". As the result then incorrect?
Have a look at pytester's method for testing outcomes. That should be stable regardless of how pytest represents the output.
lucasvanb
force-pushed
the
enormous_wall_text
branch
from
959216d
to
f5e2757
Compare
rhpvorderman
changed the title
rhpvorderman
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist