Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Nuklear): wrong autogenerated point count #979

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(Nuklear): wrong autogenerated point count #979

merged 1 commit into from
Jun 4, 2024

Conversation

wedesoft
Copy link
Contributor

@wedesoft wedesoft commented May 5, 2024

The autogenerated point count for polygon operations is wrong (array size needs to be divided by two).
I checked that the following methods are affected:

  • stroke_polyline
  • stroke_polygon
  • fill_polygon

Note that I didn't manage to build new JAR files, so I was not able to test the fix.

See below issue for screenshots.

Closes #978

@wedesoft
Copy link
Contributor Author

wedesoft commented May 5, 2024

Ok, managed to create updated JAR files. The fix works:
fixpoly

@Spasi Spasi added the Type: Bug label Jun 4, 2024
The point count for

* stroke_polyline
* stroke_polygon
* fill_polygon

is the floating-point array size divided by two.

Close #978
@Spasi Spasi merged commit 6da0cae into LWJGL:master Jun 4, 2024
@Spasi
Copy link
Member

Spasi commented Jun 4, 2024

Thank you @wedesoft!

@wedesoft
Copy link
Contributor Author

wedesoft commented Jun 4, 2024

Thanks for maintaining LWJGL3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong point count for nk_fill_polygon, nk_stroke_polygon, and nk_stroke_polyline
2 participants