fix APIUtil.apiGetManifestValue() for GraalVM native image build #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The APIUtil.apiGetManifestValue() method doesn't work in a native image generated by GraalVM, as ClassLoader.getResource() doesn't return a URL starting with "jar:" as expected when running in standard JVM environment. Instead, in native image which is run by an embedded SubstrateVM, ClassLoader.getResource() returns a URL starting with "resource:", for all resources in the classpath. This fix would make APIUtil.apiGetManifestValue() work in both standard JVM as well as in native image generated by GraalVM.
|
Hey @chirontt, thanks for the comprehensive code! I don't remember why we've been manually loading the manifest, instead of simply using |
Spasi
pushed a commit
to sormuras/lwjgl3
that referenced
this pull request
Aug 24, 2022
- Package::getImplementationVersion is unspecified when loading a JAR file from the module path. The new multi-release code uses the module descriptor to retrieve the implementation version. - Restored code that retrieves the implementation version from the JAR manifest, as a fallback. Also added the suggested fix from LWJGL#644, when running on a GraalVM native image. - Changed the LWJGL version string to match the Java version format. Close LWJGL#770 Co-authored-by: Leon Linhart <themrmilchmann@gmail.com>
Spasi
pushed a commit
to sormuras/lwjgl3
that referenced
this pull request
Aug 24, 2022
- Package::getImplementationVersion is unspecified when loading a JAR file from the module path. The new multi-release code uses the module descriptor to retrieve the implementation version. - Restored code that retrieves the implementation version from the JAR manifest, as a fallback. Also added the suggested fix from LWJGL#644, when running on a GraalVM native image. - Changed the LWJGL version string to match the Java version format. Close LWJGL#770 Co-authored-by: Leon Linhart <themrmilchmann@gmail.com>
Spasi
pushed a commit
that referenced
this pull request
Aug 24, 2022
- Package::getImplementationVersion is unspecified when loading a JAR file from the module path. The new multi-release code uses the module descriptor to retrieve the implementation version. - Restored code that retrieves the implementation version from the JAR manifest, as a fallback. Also added the suggested fix from #644, when running on a GraalVM native image. - Changed the LWJGL version string to match the Java version format. Close #770 Co-authored-by: Leon Linhart <themrmilchmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The APIUtil.apiGetManifestValue() method doesn't work in a native image
generated by GraalVM, as ClassLoader.getResource() doesn't return a URL
starting with "jar:" as expected when running in standard JVM
environment. Instead, in native image which is run by an embedded
SubstrateVM, ClassLoader.getResource() returns a URL starting with
"resource:", for all resources in the classpath.
This fix would make APIUtil.apiGetManifestValue() work in both standard
JVM as well as in native image generated by GraalVM.