Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the create member of LXCatDatabase to setup #1019

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

daanboer
Copy link
Contributor

@daanboer daanboer commented May 7, 2024

Correctly handle errors in the setup procedure.

Correctly handle errors in the setup procedure.
@daanboer daanboer enabled auto-merge (squash) May 7, 2024 18:08
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 84.64%. Comparing base (5e1cfe5) to head (94cb3b9).

Files Patch % Lines
packages/database/src/lxcat-database.ts 15.38% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
+ Coverage   82.92%   84.64%   +1.71%     
==========================================
  Files         181      125      -56     
  Lines        8564     7937     -627     
  Branches      889      806      -83     
==========================================
- Hits         7102     6718     -384     
+ Misses       1418     1199     -219     
+ Partials       44       20      -24     
Flag Coverage Δ
app ?
converter 64.82% <ø> (ø)
database 82.39% <15.38%> (-0.08%) ⬇️
schema 92.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daanboer daanboer merged commit b9295ed into main May 7, 2024
8 of 9 checks passed
@daanboer daanboer deleted the fix-setup branch May 7, 2024 18:16
@daanboer daanboer added enhancement New feature or request database and removed enhancement New feature or request labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant