Overhaul of the cross section set edit form #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daanboer
force-pushed
the
edit-form
branch
2 times, most recently
from
0a9c560
to
f710812
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
==========================================
+ Coverage 82.88% 84.90% +2.02%
==========================================
Files 181 126 -55
Lines 8569 8022 -547
Branches 889 822 -67
==========================================
- Hits 7102 6811 -291
+ Misses 1423 1191 -232
+ Partials 44 20 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Set correct state meta for states that are picked from the database.
Top-level accordion with latex reaction descriptions is implemented.
`ProcessItem` now correctly splits `info` into several `ProcessInfoItem` components. Add `onChange` functions. Adding and removing process references now works.
Setting `display: block` limits the inner components widths as desired. This results in only scrolling in vertical direction.
Greatly improves performance and usability of the set edit form.
Only includes reversibility for now. Add QoL improvements for using the process accordion: - Switching the reversibility no longer collapses the corresponding accordion item. - Accordion state is preserved when switching tabs. Add `FieldSet` components.
These maps map the id to the corresponding latex.
This component is used to select the reactants and products of a reaction in the contributor set edit form.
Treat info object type and comments.
…ities Recursively removes states and substate edges. Only compound states still need to be treated.
Add `Initial upload.` commit message to the request body.
Removes dangling `InCompound` edges, and checks whether the constituents can be removed.
Removes the now obsolete `/author/scat-css/add` and `/author/scat-css/[id]/edit` endpoints.
Only remove top border radius on species and processes accordions (not on inner accordions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27
Resolves #40
Resolves #56
Resolves #145
Also concerns #45, and the overarching #589.