openvpn 2.4.7-I603 tap-windows read write change #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.4.7 tap device read write need LPOVERLAPPED parameter.
|
Hello, There are a lot of whitespace changes in your diff, can you rework it a bit to only include the meaningful parts ? Thanks for your contribution. |
2.4.7 tap device read write need LPOVERLAPPED parameter. and set dhcp lease time not 0.
|
I have no problem testing in win7 system. |
|
As I don't have access to a Windows development station at the moment it is going to be difficult for me to review your patch. Unless someone else can provide a build report and confirm the usability of your modifications it will take some time for a validation. |
Closed
chipot
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.4.7 tap device read write need LPOVERLAPPED parameter.