Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding the same items multiple times into the same menu #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marcosalcazar
Copy link

I have found the same items being added to the same submenu multiple times on each page refresh. This is a fix for that.

@MiltonLn
Copy link
Member

Hello @marcosalcazar thanks for the contribution, before we can consider it ready, we need to add a test that demonstrates the problem first. Do you think that's something you can do?

@marcosalcazar
Copy link
Author

marcosalcazar commented Nov 16, 2020 via email

@yamijuan
Copy link
Member

Hi @marcosalcazar , any chance you can add a test?

@marcosalcazar
Copy link
Author

@MiltonLn @yamijuan Hello! I've added a small test to make sure the menu is the same after two requests, do you think this is enough? Without my change the test fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants