config: Memory leak in connman_config_provision_mutable_service

The value returned by g_key_file_get_start_group has to be deallocated by the caller.
LaakkonenJussi · Apr 24, 2017 · b92e8ff · b92e8ff
1 parent 8087a3e
commit b92e8ff
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/config.c b/src/config.c
@@ -1559,7 +1559,7 @@ int connman_config_provision_mutable_service(GKeyFile *keyfile)
 {
 	struct connman_config_service *service_config;
 	struct connman_config *config;
-	char *vfile, *group;
+	char *vfile, *group = NULL;
 	char rstr[11];
 
 	DBG("");
@@ -1595,13 +1595,14 @@ int connman_config_provision_mutable_service(GKeyFile *keyfile)
 	if (g_strcmp0(service_config->type, "wifi") == 0)
 		__connman_device_request_scan(CONNMAN_SERVICE_TYPE_WIFI);
 
+	g_free(group);
 	return 0;
 
 error:
 	DBG("Could not proceed");
 	g_hash_table_remove(config_table, vfile);
 	g_free(vfile);
-
+	g_free(group);
 	return -EINVAL;
 }