-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize autodiff functions #24
Conversation
I'll look at this this afternoon, but this is what's in #10 , right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes requested, largely on docs
Yeah and just to reiterate my question from earlier, does this accomplish what I put in issue #10 ? That is, can they now accept 3d/4d inputs or is the reshaping trick still necessary? EDIT: Answering my own question, no they do not. That's fine for this commit, but should think about whether we want that eventually. |
…ic into fix-autodiff Updating my branch to master.
…ic into fix-autodiff
…ic into fix-autodiff
I added some small comments, overall this looks good to me. Tutorial in particular looks good. |
Info:
Methods vector_jacobian_product and jacobian_vector_product can now take multiple vectors (useful for so-called block iterative methods).
Summary: