Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 44250: Invalidate QueryInfo caches after change to NameIdSettings.allowUserSpecifiedNames #669

Merged
merged 5 commits into from Nov 10, 2021

Conversation

cnathe
Copy link
Contributor

@cnathe cnathe commented Nov 8, 2021

Rationale

https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=44250

The sample type and data class queryInfo details for the name column will set the setShownInInsertView based on this allowUserSpecifiedNames setting so we need to invalidate the client side cache so that the updated information is retrieved for those table/query in the apps.

Related Pull Requests

Changes

  • Add invalidateQueryDetailsCache() helper and call it after saveNameExpressionOptions() completes

…gs.allowUserSpecifiedNames

- the sample type and data class queryInfo details for the name column will set the setShownInInsertView based on this allowUserSpecifiedNames setting so we need to invalidate the client side cache so that the updated information is retrieved for those table/query
@labkey-chrisj
Copy link

Just as a heads-up, 21.11 release in biologics is failing a lot
image
...with typeErrors complaining that t.lookup.queryName is null:
image

@cnathe cnathe merged commit f5d4545 into release21.11-SNAPSHOT Nov 10, 2021
@cnathe cnathe deleted the 21.11_fb_allowUserSpecifiedNames44250 branch November 10, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants