Issue 43374: + and % in container paths not properly encoded when creating exp.data rows in FileImporter #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating exp.data rows in FileImporter
labkey-susanh
approved these changes
Jun 28, 2021
| // Hack for issue 43374 - encode special characters in container paths. Need to push this encoding | ||
| // into FilesWebPart._getRootPath(), but other codepaths are doing their own compensation so it's a more | ||
| // involved change | ||
| rootDavUrl = rootDavUrl.replace("%", "%25").replace("+", "%2B"); |
There was a problem hiding this comment.
Seems OK as long as we know that child.get("webdavURL") is not yet been through any encoding (such that a % is present from an encoding and thus might get encoded twice).
There was a problem hiding this comment.
@labkey-susanh yes, it's always unencoded. See FilesWebPart._getRootPath() where it calls c.getPath() instead of c.getEncodedPath(). I think ultimately that call should change and do the encoding, but other places in the client code are doing their own encoding right now.
RosalineP
pushed a commit
that referenced
this pull request
Jun 28, 2021
…ating exp.data rows in FileImporter (#2408) Co-authored-by: labkey-jeckels <Josh Eckels>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
A previous fix addressed special characters in the files that are part of the folder import, but there's a related problem when the target folder has special characters in its own name
Changes