Issue 44126: CommandTasks fail on remote pipeline servers #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2021 15:38
Fix problems running CommandTasks on remote servers where we don't have access to the LK DB
Improvements on handling of web vs remote server detection and error reporting
labkey-adam
reviewed
Oct 15, 2021
| @@ -646,6 +646,9 @@ public String getApiKey() | |||
| { | |||
| return _apikey; | |||
| } | |||
|
|
|||
| @Override | |||
| public abstract void close(); | |||
There was a problem hiding this comment.
This is causing a build break in CromwellGctTask (MacCossLabModules)... need to remove catch (IOException) there
labkey-adam
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Remote pipeline servers fail to run CommandTasks because we've introduced code that only works when invoked on the web server where we have the DB connection available
Changes