Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce dataset id collisions #2707

Merged
merged 2 commits into from Oct 25, 2021
Merged

reduce dataset id collisions #2707

merged 2 commits into from Oct 25, 2021

Conversation

labkey-matthewb
Copy link
Contributor

@labkey-matthewb labkey-matthewb commented Oct 20, 2021 •
edited

Rationale

https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=43491
21.11 version of this pull request #2701

Related Pull Requests

Changes

labkey-adam
labkey-adam approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue comment suggested starting dataspace datasets at 100,000, but PR starts at 10,000. That seems fine, but wanted to note the discrepancy.

@labkey-matthewb labkey-matthewb merged commit c5b9a6d into develop Oct 25, 2021
@labkey-matthewb labkey-matthewb deleted the fb_datasetid_43491_dev branch October 25, 2021 17:33
@labkey-adam labkey-adam mentioned this pull request Oct 29, 2021
Merged
@labkey-tchad labkey-tchad mentioned this pull request Nov 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-adam labkey-adam labkey-adam approved these changes

@labkey-ians labkey-ians Awaiting requested review from labkey-ians

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@labkey-matthewb @labkey-adam