Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 44814: Exception from poor return URL parsing behavior #3097

Merged
merged 1 commit into from Feb 26, 2022
Merged

Issue 44814: Exception from poor return URL parsing behavior #3097

merged 1 commit into from Feb 26, 2022

Conversation

labkey-jeckels
Copy link
Contributor

Rationale

Fully qualified returnURL parameters can cause StringExceptionOutOfBoundsExceptions in some codepaths

Changes

  • Check if there's any more of the string to include in the message before grabbing the character

@labkey-jeckels labkey-jeckels requested a review from a team February 25, 2022 22:48
@labkey-jeckels labkey-jeckels merged commit 54d7982 into develop Feb 26, 2022
@labkey-jeckels labkey-jeckels deleted the fb_44814_returnUrlParsing branch February 26, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-adam labkey-adam labkey-adam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@labkey-jeckels @labkey-adam