Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inadvertent change to the casing of column names returned by DatasetUpdateService.getRow(). #3161

Merged

Conversation

labkey-matthewb
Copy link
Contributor

Copy link
Contributor

@labkey-martyp labkey-martyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkey-matthewb Not sure if you saw my message, there are some test failures with this. Looks like a transaction/connection issue. I have not really investigated but it does repro locally if you run a test like StudyMergeParticipantsTest.

https://teamcity.labkey.org/buildConfiguration/LabKey_2111Release_Community_DailySuites_DailyEPostgres/1752445?showRootCauses=false&expandBuildChangesSection=true&expandBuildTestsSection=true

Copy link
Contributor

@labkey-martyp labkey-martyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks like all study tests are passing. Looks good.

@labkey-matthewb labkey-matthewb merged commit 5ba6ac3 into release21.11-SNAPSHOT Mar 25, 2022
@labkey-matthewb labkey-matthewb deleted the 21.11_fb_45088_column_name_casing branch March 25, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants