Adjust SecurityManager permissions methods to take a SecurableResource instead of a SecurityPolicy #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instead of a SecurityPolicy
labkey-jeckels
approved these changes
Jun 9, 2022
| @@ -194,6 +194,7 @@ public WebdavResource find(String child) | |||
| new Date() | |||
| ); | |||
|
|
|||
| // TODO: This is a problem! | |||
There was a problem hiding this comment.
Reminder to loop back on this code
|
@labkey-jeckels See my chat (to you & Matt) about this and related PRs... I'm inclined to ditch the whole lot and not pursue this direction. We can discuss if you'd like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Passing in a
SecurableResourcegives us more flexibility downstream, e.g., for linked schemas. https://www.labkey.org/home/Developer/issues/Secure/issues-details.view?issueId=45251