Refactor Resource interface #5422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileUtil.appendName()
…fb_resource_refactor
|
Did this break the FileContent tests? |
labkey-jeckels
approved these changes
May 1, 2024
| return new Path(subDirs); | ||
| // TODO: Schema names can contains slashes (e.g. assay names) | ||
| // TODO: Not sure how the callers deal with this, when they map these into file-system directories. | ||
| // TODO: We could throw IllegalArgument and let the caller handle it. |
There was a problem hiding this comment.
I'd vote for replacing / with_. If we throw a runtime exception, it's unlikely that callers will know they may need to deal with it.
There was a problem hiding this comment.
I didn't want to break things in release branch.
Yes, on develop |
Hmm, passed several times... Let's see what teamcity says... |
The sendDigest functionality seems to be sensitive to database/webserver time mismatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Remove ambiguous methods in interface Resource.
Prefer Path and Path.Part to ambiguous usage of String.
Related Pull Requests
Changes
Path.getPathPart()
FileUtil.appendName()