Issue 50132: importing folder archive with identical sample IDs in diferent sample types fails #5462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent sample types - fails
|
ERROR: A pull request from |
|
ERROR: A pull request from |
labkey-klum
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The sample lookup columns in assay data are exported as sample names during folder export. When there are duplicate sample names across different samples types, the folder import fails with unable to resolve sample error.
This PR modifies assay result data import to first try to resolve assay result samples names from already processed material inputs information (which was exported using lsid and hence resolvable).
This PR does not address sample resolution for assay Run fields, which currently exports sample row id, and doesn't resolve (but doesn't error out either).
Related Pull Requests
Changes