Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create properties template and remove driver binaries #870

Merged
merged 21 commits into from Oct 4, 2021

Conversation

labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Sep 24, 2021

Rationale

test.properties doesn't give any guidance regarding how to use it. It also ends up in changelists because people often edit it. This removes test.properties from source control and replaces it with test.properties.dist. The gradle plugin will generate test.properties if it is missing.
The chromedriver and geckodriver binaries checked in are out of date. It is bad practice to commit binaries to source control anyway so we will remove them and require folks to install them manually to run tests.

Related Pull Requests

Changes

  • Remove chromedriver/geckodriver binaries
  • Remove test.properties from source control and add to .gitignore
  • Add annotated test.properties.template
  • Generate test.properties from test.properties.template

@labkey-tchad labkey-tchad marked this pull request as ready for review September 27, 2021 18:06
@labkey-tchad labkey-tchad requested review from a team and labkey-sweta and removed request for a team September 27, 2021 18:06
@labkey-tchad labkey-tchad changed the title Update test setup process Use properties template and remove driver binaries Sep 29, 2021
@labkey-tchad labkey-tchad changed the title Use properties template and remove driver binaries Create properties template and remove driver binaries Sep 29, 2021
@labkey-chrisj
Copy link
Contributor

A little manual testing on my part says the only missing thing is documentation calling out the existence of the gradle command to create test.properties from its template: gradlew :server:testAutomation:initProperties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants