New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create properties template and remove driver binaries #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
requested review from
a team and
labkey-sweta
and removed request for
a team
September 27, 2021 18:06
labkey-sweta
approved these changes
Sep 27, 2021
labkey-tchad
changed the title
Update test setup process
Use properties template and remove driver binaries
Sep 29, 2021
labkey-tchad
changed the title
Use properties template and remove driver binaries
Create properties template and remove driver binaries
Sep 29, 2021
A little manual testing on my part says the only missing thing is documentation calling out the existence of the gradle command to create test.properties from its template: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
test.properties
doesn't give any guidance regarding how to use it. It also ends up in changelists because people often edit it. This removestest.properties
from source control and replaces it withtest.properties.dist
. The gradle plugin will generatetest.properties
if it is missing.The chromedriver and geckodriver binaries checked in are out of date. It is bad practice to commit binaries to source control anyway so we will remove them and require folks to install them manually to run tests.
Related Pull Requests
Changes
test.properties
from source control and add to .gitignoretest.properties.template
test.properties
fromtest.properties.template