This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
[Snyk] Security upgrade xml-encryption from 1.3.0 to 2.0.0 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rl login endpoint
Converts exception to error when calling getSamlRequestUrl with an empty identityProviderUrl
Revving the version to 3.0.6 for a patch release
Remove moment as a dev dependency
* Added digest issue test * bumped library * remove github tag * Changed tag
Removing the package-lock.json file
* Improve error message when the provided signing certificate is invalid * Convert indentation to spaces
…h0#74) * Added tests for the encoded XML value in an AttributeValue field * Updated the xmldom dependency to point to a release tag.
auth0#77) We used to parse `options.identityProviderUrl` assuming it was a string, which failed when it wasn't. We'd fixed this in Samlp.getSamlRequestUrl(), but its siblings getSamlRequestParams() and getSamlRequestForm() were still susceptible.
Bumping version to 3.0.9
sec: fix signature location lookup
3.0.11 Handle exception when signing a malformed requestTemplate
## ✏️ Changes There is a situation in which the @@ VAR @@ can get goofed up and contain strings that will include part of the template itself. This will not parse correctly and throws an exception in the replace phase of the regex matching. I've wrapped it in a try/catch to prevent it from bringing the process down. Noting that this area looks problematic as it was recently patched in auth0#88 Version bumped to `3.0.12`. ## 🔗 References [Sentry Issue](https://sentry.io/auth0/auth0-server/issues/617753396/events/25564560312/) ## 🎯 Testing ✅ This change has unit test coverage
The `supplant` function will explode when a template is passed in this manner, so this will return a corresponding error message when handing the try/catch in this way. If we add proper XML validation down the line, we can widen this out.
* add certificate expiration checking as an option (off by default) Drops Node4 support as well, though it was already failing on Node4 in master changes per machuga comments changes per machuga comments remove separate supported-versions list for saml * restore test we lost in bad squash * change some vars to lets and camel to snake case in tests * add test to ensure we can allow expired certs if we choose to * remove unneeded comment from tests
* [Node 10] Update x509 * 4.0.0 * Update travis * get rid of npm install
* remove cryptiles * bump xml-encryption * express upgrade
* use last xml-crypto
Use custom npm lib with custom versions of xmldom Tag v0.1.19-auth0.2 is now version v0.1.22
chore(ci): configure Semantic Release publishing
chore: use npm i instead of npm ci
Addresses: ``` npm WARN deprecated xmldom@0.1.27: Deprecated due to CVE-2021-21366 resolved in 0.5.0 ```
fix(pkg): upgrade xml-crypto to latest version
## [4.5.2](v4.5.1...v4.5.2) (2021-11-24) ### Bug Fixes * **pkg:** upgrade xml-crypto to latest version ([5702273](5702273))
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEFORGE-2330875 - https://snyk.io/vuln/SNYK-JS-NODEFORGE-2331908
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR
Vulnerabilities that will be fixed
With an upgrade:
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
SNYK-JS-NODEFORGE-2330875
Why? Recently disclosed, Has a fix available, CVSS 6.3
SNYK-JS-NODEFORGE-2331908
(*) Note that the real score may have changed since the PR was raised.
Commit messages
Package name: xml-encryption
The new version differs by 4 commits.See the full diff
Check the changes in this PR to ensure they won't cause issues with your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic