Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all simulation data for the months defined in the configuration are generated #38

Closed
soaressgabriel opened this issue Aug 22, 2021 · 0 comments · Fixed by #39
Closed
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@soaressgabriel
Copy link
Collaborator

Based on @LINAMARIAOSORIO's tests.

Subject of issue

One month is missing in the data generated from the simulation of the period defined in the configuration. The section specifying the model simulation period in the configuration file has been configured in the following ways:

[SIM_TIME]
start = 01/01/2000
end = 01/10/2000
(rubem-dev) E:\Workspaces\RUBEM>python rubem.py --configfile "E:\Workspaces\Dataset\REPAR\config-repar-teste.ini"
RUBEM::Started
RUBEM::Reading configuration file... OK
RUBEM::Running dynamic model...
RUBEM::Reading input files... OK
.Time: 1
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 1 of 9
.Time: 2
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 2 of 9
.Time: 3
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 3 of 9
.Time: 4
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 4 of 9
.Time: 5
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 5 of 9
.Time: 6
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 6 of 9
.Time: 7
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 7 of 9
.Time: 8
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 8 of 9
.Time: 9
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 9 of 9
RUBEM::Dynamic model runtime: 1.39 seconds
RUBEM::Converting *.tss files to *.csv... OK
RUBEM::Finished

and

[SIM_TIME]
start = 01/01/2000
end = 31/10/2000
(rubem-dev) E:\Workspaces\RUBEM>python rubem.py --configfile "E:\Workspaces\Dataset\REPAR\config-repar-teste.ini"
RUBEM::Started
RUBEM::Reading configuration file... OK
RUBEM::Running dynamic model...
RUBEM::Reading input files... OK
.Time: 1
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 1 of 9
.Time: 2
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 2 of 9
.Time: 3
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 3 of 9
.Time: 4
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 4 of 9
.Time: 5
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 5 of 9
.Time: 6
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 6 of 9
.Time: 7
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 7 of 9
.Time: 8
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 8 of 9
.Time: 9
        Interception... OK
        Evapotranspiration... OK
        Surface Runoff... OK
        Lateral Flow... OK
        Recharge Flow... OK
        Baseflow... OK
        Soil Balance... OK
        Runoff... OK
Exporting variables to files... OK 
Ending cycle 9 of 9
RUBEM::Dynamic model runtime: 1.37 seconds
RUBEM::Converting *.tss files to *.csv... OK
RUBEM::Finished

In both, the result was the same, the absence of a month in the generated data.

Note that it doesn't matter if we specify the beginning of the month (in which case the number of months generated would be correct) or the end of the month (in which case the number of months generated would be incorrect).

My environment

N/A

Steps to Reproduce

  1. Run the model with a valid configuration file;
  2. Observe the number of cycles and the series data generated.

Expected behavior

Data is generated from the simulation of the entire period defined in the section that specifies it in the configuration file.

Current behavior

One month is missing in the data generated from the simulation of the period defined in the configuration. This happens even with the section that specifies the model simulation period in the configured configuration file covering all days of the last month.

@soaressgabriel soaressgabriel added the bug Something isn't working label Aug 22, 2021
@soaressgabriel soaressgabriel self-assigned this Aug 22, 2021
@soaressgabriel soaressgabriel added this to To do in Issues via automation Aug 22, 2021
soaressgabriel added a commit that referenced this issue Aug 22, 2021
…-the-month

Fix #38 Consider the entire end month
Issues automation moved this from To do to Done Aug 22, 2021
@soaressgabriel soaressgabriel linked a pull request Aug 22, 2021 that will close this issue
@soaressgabriel soaressgabriel added this to the v0.1.0-alpha milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant