New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a configuration system within the application that can handle multiple formats #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soaressgabriel
changed the title
Add new configuration classes for Rubem
Add new configuration classes for RUBEM
Jan 22, 2024
…ing/rubem-configuration
soaressgabriel
changed the title
Add new configuration classes for RUBEM
Add new configuration classes
Feb 8, 2024
soaressgabriel
changed the title
Add new configuration classes
Implement a configuration system within the application that can handle multiple formats
Feb 15, 2024
…o boolean in ModelConfiguration class
.ini and preliminary json tested |
LINAMARIAOSORIO
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
*.ini
files, JSON files, and Python dictionaries;*.ini
configurations;appsettings.json
(mapped torubem.configuration.app_settings import AppSettings
);"--skip-inputs-validation"
option in CLI to skip the verification step.Related Issue
Motivation and context
*.ini
files for configuration as highlighted in issue Implement a new configuration system within the application that can handle multiple formats #104.How has this been tested
Screenshots