Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in the implementation of the Total Discharge equation #106

Merged
merged 1 commit into from Jan 24, 2024
Merged

Fix error in the implementation of the Total Discharge equation #106

merged 1 commit into from Jan 24, 2024

Conversation

soaressgabriel
Copy link
Collaborator

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Added tests for changed code.
  • Updated documentation for changed code.

Description

  • Where there was ("INITIAL_SOIL_CONDITIONS", "T_ini"), ("CALIBRATION", "x") was placed.

Related Issue

Motivation and context

  • Correction of error in the implementation of the model equations.

How has this been tested

  • N/A

Screenshots

  • N/A

@soaressgabriel soaressgabriel self-assigned this Jan 24, 2024
@soaressgabriel soaressgabriel linked an issue Jan 24, 2024 that may be closed by this pull request
Fix error in the implementation of the Total Discharge equation #105
Closed
LINAMARIAOSORIO
LINAMARIAOSORIO approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@LINAMARIAOSORIO LINAMARIAOSORIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved!

@soaressgabriel soaressgabriel merged commit fd2c8ae into main Jan 24, 2024
@soaressgabriel soaressgabriel deleted the fix/105-fix-error-in-the-implementation-of-the-total-discharge-equation branch January 24, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LINAMARIAOSORIO LINAMARIAOSORIO LINAMARIAOSORIO approved these changes

Assignees

@soaressgabriel soaressgabriel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix error in the implementation of the Total Discharge equation
2 participants
@soaressgabriel @LINAMARIAOSORIO