Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional specification of a LDD raster in the model simulation configuration #132

Conversation

soaressgabriel
Copy link
Collaborator

@soaressgabriel soaressgabriel commented Feb 19, 2024

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Added tests for changed code.
  • Updated documentation for changed code.

Description

Related Issue

Motivation and context

How has this been tested

  • Manually.

Screenshots

  • N/A

This commit refactors the logic for creating the Local Drain Direction (LDD) map in the RUBEM class. Instead of always generating the LDD map based on the DEM, the code now checks if a specific LDD file is provided. If a file is provided, it reads the LDD map from the file. If no file is provided, it generates the LDD map based on the DEM.
@soaressgabriel soaressgabriel marked this pull request as ready for review February 22, 2024 23:18
Copy link
Collaborator

@LINAMARIAOSORIO LINAMARIAOSORIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soaressgabriel soaressgabriel merged commit 3e4c020 into main Feb 23, 2024
4 checks passed
@soaressgabriel soaressgabriel deleted the feat/120-add-possibility-to-optionally-specify-local-drain-direction-ldd-raster-in-the-model-configuration branch March 15, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to optionally specify Local Drain Direction (LDD) raster in the model configuration
2 participants