Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make timespans human-readable #148

Merged
merged 4 commits into from Feb 23, 2024
Merged

Make timespans human-readable #148

merged 4 commits into from Feb 23, 2024

Conversation

soaressgabriel
Copy link
Collaborator

@soaressgabriel soaressgabriel commented Feb 23, 2024 •
edited

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Added tests for changed code.
  • Updated documentation for changed code.

Description

  • Added humanize dependency;
  • Added section for language configuration for the application in appsettings.json.

Related Issue

Motivation and context

How has this been tested

  • Manually.

Screenshots

  • N/A

@soaressgabriel soaressgabriel self-assigned this Feb 23, 2024
@soaressgabriel soaressgabriel linked an issue Feb 23, 2024 that may be closed by this pull request
Make timespans human-readable #118
Closed
@soaressgabriel soaressgabriel changed the title Make timespans human readable Make timespans human-readable Feb 23, 2024
@soaressgabriel soaressgabriel marked this pull request as ready for review February 23, 2024 14:51
LINAMARIAOSORIO
LINAMARIAOSORIO approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@LINAMARIAOSORIO LINAMARIAOSORIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soaressgabriel soaressgabriel merged commit 826b8fa into main Feb 23, 2024
4 checks passed
@soaressgabriel soaressgabriel mentioned this pull request Feb 23, 2024
Merged
4 tasks
@soaressgabriel soaressgabriel deleted the 118-make-timespans-human-readable branch March 15, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LINAMARIAOSORIO LINAMARIAOSORIO LINAMARIAOSORIO approved these changes

Assignees

@soaressgabriel soaressgabriel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make timespans human-readable
2 participants
@soaressgabriel @LINAMARIAOSORIO