Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking for files in the output directory when it doesn't exist #149

Conversation

soaressgabriel
Copy link
Collaborator

@soaressgabriel soaressgabriel commented Feb 23, 2024

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Added tests for changed code.
  • Updated documentation for changed code.

Description

  • Moves file listing in the repository to after successful creation of the directory when it does not exist.

Related Issue

Motivation and context

How has this been tested

  1. Configure a simulation to use an output directory (valid path) that does not exist;
  2. Run the simulation;
  3. Verify that the output directory was created and the files resulting from the simulation are present.

Screenshots

  • N/A

@soaressgabriel soaressgabriel self-assigned this Feb 23, 2024
@soaressgabriel soaressgabriel marked this pull request as ready for review February 23, 2024 15:00
Copy link
Collaborator

@LINAMARIAOSORIO LINAMARIAOSORIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested!

@soaressgabriel soaressgabriel merged commit 4eaa5df into main Feb 23, 2024
4 checks passed
@soaressgabriel soaressgabriel deleted the fix/146-fix-checking-for-files-in-the-output-directory-when-it-doesnt-exist branch March 15, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix checking for files in the output directory when it doesn't exist
2 participants