Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename modules to hydrological_processes and update imports #165

Conversation

soaressgabriel
Copy link
Collaborator

@soaressgabriel soaressgabriel commented Mar 6, 2024

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Added tests for changed code.
  • Updated documentation for changed code.

Description

  1. Rename modules directory to hydrological_processes;
  2. Reorganizes hydrological processes as classes composed of static methods;
  3. Rearrange imports in __init__.py from hydrological_processes;
  4. Updates method and argument naming;
  5. Updates imports to reflect changes;
  6. Updates tests to reflect changes;

Related Issue

Motivation and context

How has this been tested

  • The behavior and simulation results of the model must remain unchanged in relation to the current implementation:

    1. Set up a simulation enabling all simulation outputs (rasters and tables);
    2. Run the simulation;
    3. Verify that the specified rasters and tables files were created in the output directory.

Screenshots

  • N/A

@soaressgabriel soaressgabriel self-assigned this Mar 6, 2024
@soaressgabriel soaressgabriel linked an issue Mar 6, 2024 that may be closed by this pull request
Copy link
Collaborator

@LINAMARIAOSORIO LINAMARIAOSORIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soaressgabriel soaressgabriel merged commit b979e21 into main Mar 8, 2024
4 checks passed
@soaressgabriel soaressgabriel deleted the 115-rename-modules-to-hydrological_processes-and-update-imports branch March 8, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants