Enhancement of the parameters management for the opencv camera #71
Conversation
One class for Linux using v4l2-ctl and the other for other situation
Same method as for CameraGstreamerV4l2
There was a problem hiding this comment.
Thank you @PIERROOOTT for this nice contribution, it greatly improves the capabilities of OpenCV and GStreamer cameras on both Linux and Windows.
I appreciate your efforts for structuring and documenting your code.
There are still a few remarks here and there, half about code style and half about actual code issues.
I think the fact that a different class is called depending on the platform should be mentioned in the documentation. The differences between the OpenCV and GStreamer cameras can also be described a bit further in the documentation of each of these classes.
There was a problem hiding this comment.
Everything seems fine now, I tested it and it works fine !
Thank you @PIERROOOTT !
I'm still adding minor unrelated changes on my side before merging.
It provides information on the release when features were added, changed, or removed
Currently, there is one class for cameras using opencv. V4l2 is used to get available formats when it is installed. The different parameters of the camera can not be changed. It is not very convenient for the user.
In this PR, the opencv camera class is split in two classes in two different files (f0713e6), one for Linux if v4l-utils is installed and one for the other operating systems. The first one is based on v4l2 to get and set the parameters (32e5907). The second one can also now set some parameters by using the opencv library (4e191a1).
The v4l2 opencv camera and the v4l2 gstreamer camera are very similar, that is why a parent class for all the operations using v4l2 has been created (17d9c1d, 58ef495, 48bf1a6).
Closes #17 and closes #65