Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging-related files #77

Merged
merged 4 commits into from
Nov 26, 2023

Conversation

WeisLeDocto
Copy link
Member

As detailed in #68, most of the project's metadata and build options should be moved from the existing setup.py file to the now very basic pyproject.toml. This is achieved in this PR.

The pyproject.toml file now holds most of the information previously contained in setup.py. Because it is not compatible with the pyproject.toml specifications, only the information about extension modules is kept in setup.py. If the objects relying on extension modules are ever removed from Crappy, then only the pyproject.toml file will remain.

Closes #68

Only the code managing the extension modules remains in setup.py
setup.py might be totally removed in a future version if the objects requiring the extension modules are removed from the module
They became useless after changes brought in f2148a2
@WeisLeDocto WeisLeDocto added structure Signals an issue that concerns the structure of the repo update Signals an issue that entails a section of code to be updated labels Nov 26, 2023
@WeisLeDocto WeisLeDocto self-assigned this Nov 26, 2023
@WeisLeDocto WeisLeDocto linked an issue Nov 26, 2023 that may be closed by this pull request
@WeisLeDocto WeisLeDocto merged commit 6b299ee into develop Nov 26, 2023
1 check passed
@WeisLeDocto WeisLeDocto deleted the feature/update_packaging_related_files branch November 26, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
structure Signals an issue that concerns the structure of the repo update Signals an issue that entails a section of code to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move most project metadata from setup.py to pyproject.toml
1 participant