NLIC-1980: Group models & packages in a license bundle #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-rudkovskiy
force-pushed
the
RVA/NLIC-1980/Group_models_&_packages_in_a_license_bundle
branch
from
bfc0ebe
to
a0431ad
Compare
v-rudkovskiy
force-pushed
the
RVA/NLIC-1980/Group_models_&_packages_in_a_license_bundle
branch
from
3d3e789
to
6151862
Compare
kkorotkov
force-pushed
the
master
branch
18 times, most recently
from
8b76082
to
bd5e210
Compare
v-rudkovskiy
commented
Feb 22, 2024
NetLicensingClient/src/main/java/com/labs64/netlicensing/service/BundleService.java
Outdated
Show resolved
Hide resolved
v-rudkovskiy
commented
Feb 22, 2024
NetLicensingClient/src/main/java/com/labs64/netlicensing/domain/vo/BundleObtainParameters.java
Outdated
Show resolved
Hide resolved
kkorotkov
reviewed
Feb 23, 2024
| @@ -262,7 +262,7 @@ public Response validateLicensee(@PathParam("licenseeNumber") final String licen | |||
| * | |||
| * @param licenseeNumber | |||
| * licensee number | |||
| * @param transfer | |||
| * @param transferLicensee | |||
There was a problem hiding this comment.
The entire method signature of this mock is incorrect, and it works solely because the 'transferLicensee' parameter is unused, thus eluding test coverage, which is the actual problem. Therefore, this suggested javadoc revision seems pointless.
kkorotkov
approved these changes
Feb 23, 2024
v-rudkovskiy
deleted the
RVA/NLIC-1980/Group_models_&_packages_in_a_license_bundle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.