Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Craftportal #1138

Merged
merged 11 commits into from
Jun 4, 2024
Merged

Craftportal #1138

merged 11 commits into from
Jun 4, 2024

Conversation

Craftportal
Copy link
Contributor

@Craftportal Craftportal commented Jun 2, 2024 •
edited
Loading

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

github-actions[bot]
github-actions bot previously requested changes Jun 2, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Invalid url. URL has to start with https:// (social.discord)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

DoJapHD
DoJapHD requested changes Jun 2, 2024
View reviewed changes
minecraft_servers/craftportal/background.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

minecraft_servers/craftportal/background@2x.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

minecraft_servers/craftportal/manifest.json Outdated
"de"
],
"social":{
"web": "https://www.craftportal.net",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-existent

@Craftportal Craftportal requested a review from DoJapHD June 4, 2024 14:52
@DoJapHD DoJapHD merged commit 0405e6f into LabyMod:master Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoJapHD DoJapHD DoJapHD approved these changes

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Craftportal @DoJapHD