Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ikara #1187

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Add Ikara #1187

merged 6 commits into from
Jun 26, 2024

Conversation

oipika
Copy link
Contributor

@oipika oipika commented Jun 25, 2024

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/ikara/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress this file

"social": {
"web": "https://ikara.gg",
"web_shop": "https://store.ikara.gg",
"web_support": "https://ikara.gg/discord",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web_support cannot be a discord server or forum; use a contact form, faq or similar or remove

"nice_name": "Ikara",
"direct_ip": "ikara.gg",
"server_wildcards": [
"%.ikara.gg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like a real wildcard
image

"en"
],
"social": {
"web": "https://ikara.gg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real content; if website does not exist, remove it

"factions": {
"name": "Factions",
"color": "#7CFDFF",
"url": "https://www.Ikara.gg/Discord",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reserved for a own landing page for your gamemode, not a general url

"practice": {
"name": "Practice",
"color": "#FFE287",
"url": "https://www.Ikara.gg/Discord",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reserved for a own landing page for your gamemode, not a general url

"survival": {
"name": "Survival",
"color": "#8CFCB9",
"url": "https://www.Ikara.gg/Discord",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reserved for a own landing page for your gamemode, not a general url

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/ikara/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/ikara/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@oipika oipika requested a review from maaaathis June 25, 2024 08:08
@DoJapHD DoJapHD merged commit 9619d48 into LabyMod:master Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants