Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest.json #1237

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Update manifest.json #1237

merged 5 commits into from
Aug 6, 2024

Conversation

Im7S1
Copy link
Contributor

@Im7S1 Im7S1 commented Aug 1, 2024

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/blocksmc/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@Im7S1
Copy link
Contributor Author

Im7S1 commented Aug 4, 2024

New

Copy link
Contributor

@maaaathis maaaathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please fix your indentations

@@ -12,10 +12,14 @@
"tiktok": "blocksmctiktok",
"instagram": "BlocksMC",
"discord": "https://discord.gg/BlocksMC",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"discord": "https://discord.gg/BlocksMC",
"discord": "https://discord.gg/BlocksMC"

"primary": "#0e0600",
"background": "#ffc103"
"primary": "#001414",
"background": "#008cd3"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
},

@maaaathis maaaathis mentioned this pull request Aug 4, 2024
5 tasks
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/blocksmc/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@Im7S1 Im7S1 requested a review from maaaathis August 6, 2024 15:09
@DoJapHD DoJapHD merged commit 8b10d55 into LabyMod:master Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants