Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute paths in the example agent.cfg don't match with internal paths for image mtconnect/agent:2.2.0.16 #251

Open
Dowster64 opened this issue May 9, 2024 · 2 comments · May be fixed by #252
Assignees
Labels
application:agent Anything related to a specific application

Comments

@Dowster64
Copy link

Dowster64 commented May 9, 2024

Hi,
We installed Ladder using git clone onto a chromebook on 7/5/24 (UK/ AUS format date) . We had to modify the Grafana port from port 80 (I think to >1000) - we used 3000 externally but this is a chromebook issue.
We did run into issues with the current agent.cfg paths for the agent.xml file and the stylesheet settings.
Current settings and suggested changes to the agent.cfg file:

# note only the relevant lines are shown
Devices = /data/agent/agent.xml   # Original - note the docker-compose.yaml mounts to:
#  volumes:
#       - ../setups/$SETUP/volumes/agent:/mtconnect/config # should have agent.cfg, agent.xml
# This worked for us:
Devices = ./agent.xml
# This would likely work too:
Devices = /mtconnect/config/agent.xml

# Under the Stylesheets config:

Path = /etc/mtconnect/styles  # Original 
Path = /mtconnect/data/styles            # new  

 Path = /etc/mtconnect/styles/favicon.ico # Original 
 Path = /mtconnect/data/styles/favicon.ico # new

I'll try an do a pull request, but these are changes we made to get the container/ service running. However the path mismatch might be different for different agent images, so a Dockerfile and a build might be better controlled?
Thanks again for a great complete solution around MTConnect, data persistence and visualisation!

ottobolyos added a commit to ottobolyos/ladder99 that referenced this issue May 9, 2024
@ottobolyos ottobolyos self-assigned this May 9, 2024
@ottobolyos ottobolyos added the application:agent Anything related to a specific application label May 9, 2024
@ottobolyos
Copy link
Collaborator

ottobolyos commented May 9, 2024

@Dowster64, thanks for opening this issue! 🙏

We installed Ladder using git clone onto a chromebook on 7/5/24 (UK/ AUS format date) . We had to modify the Grafana port from port 80 (I think to >1000) - we used 3000 externally but this is a chromebook issue.

Changing/overriding the configuration can be done using the $repo_root/setups/$setup/services/docker-compose.yaml, e.g. the ports can be changed by adding .services.grafana.ports to that file.

# This worked for us:
Devices = ./agent.xml
# This would likely work too:
Devices = /mtconnect/config/agent.xml

Indeed, it is a bug on our side.

And while both paths work, the former might be preferred.

Path = /etc/mtconnect/styles  # Original 
Path = /mtconnect/data/styles            # new  

Path = /etc/mtconnect/styles/favicon.ico # Original 
Path = /mtconnect/data/styles/favicon.ico # new

Both of these paths needs to be fixed. Your new paths are correct.

@ottobolyos ottobolyos linked a pull request May 9, 2024 that will close this issue
@ottobolyos
Copy link
Collaborator

Anyway, I have created the PR (see #252).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application:agent Anything related to a specific application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants