Skip to content

Commit

Permalink
LibJS+LibLocale: Replace relative time formatting with ICU
Browse files Browse the repository at this point in the history
This uses ICU for all of the Intl.RelativeTimeFormat prototypes, which
lets us remove all data from our relative-time format generator.
  • Loading branch information
trflynn89 authored and awesomekling committed Jun 15, 2024
1 parent f7a83e5 commit 7f9ccd3
Show file tree
Hide file tree
Showing 9 changed files with 331 additions and 609 deletions.
13 changes: 0 additions & 13 deletions Meta/CMake/locale_data.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ if (ENABLE_UNICODE_DATABASE_DOWNLOAD)
set(PLURAL_RULES_DATA_HEADER PluralRulesData.h)
set(PLURAL_RULES_DATA_IMPLEMENTATION PluralRulesData.cpp)

set(RELATIVE_TIME_FORMAT_DATA_HEADER RelativeTimeFormatData.h)
set(RELATIVE_TIME_FORMAT_DATA_IMPLEMENTATION RelativeTimeFormatData.cpp)

invoke_generator(
"LocaleData"
Lagom::GenerateLocaleData
Expand All @@ -63,21 +60,11 @@ if (ENABLE_UNICODE_DATABASE_DOWNLOAD)
"${PLURAL_RULES_DATA_IMPLEMENTATION}"
arguments -r "${CLDR_CORE_PATH}" -l "${CLDR_LOCALES_PATH}"
)
invoke_generator(
"RelativeTimeFormatData"
Lagom::GenerateRelativeTimeFormatData
"${CLDR_VERSION_FILE}"
"${RELATIVE_TIME_FORMAT_DATA_HEADER}"
"${RELATIVE_TIME_FORMAT_DATA_IMPLEMENTATION}"
arguments -d "${CLDR_DATES_PATH}"
)

set(LOCALE_DATA_SOURCES
${LOCALE_DATA_HEADER}
${LOCALE_DATA_IMPLEMENTATION}
${PLURAL_RULES_DATA_HEADER}
${PLURAL_RULES_DATA_IMPLEMENTATION}
${RELATIVE_TIME_FORMAT_DATA_HEADER}
${RELATIVE_TIME_FORMAT_DATA_IMPLEMENTATION}
)
endif()
1 change: 0 additions & 1 deletion Meta/Lagom/Tools/CodeGenerators/LibLocale/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
lagom_tool(GenerateLocaleData SOURCES GenerateLocaleData.cpp LIBS LibMain)
lagom_tool(GeneratePluralRulesData SOURCES GeneratePluralRulesData.cpp LIBS LibMain)
lagom_tool(GenerateRelativeTimeFormatData SOURCES GenerateRelativeTimeFormatData.cpp LIBS LibMain)

This file was deleted.

Loading

0 comments on commit 7f9ccd3

Please sign in to comment.