LibWeb: Mark bitmaps passed to Skia as immutable

All bitmaps passed to Skia during rendering are not supposed to be mutated.
LadybirdBrowser · Jul 15, 2024 · af9b91e · af9b91e
1 parent 31eec0a
commit af9b91e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/Userland/Libraries/LibWeb/Painting/DisplayListPlayerSkia.cpp b/Userland/Libraries/LibWeb/Painting/DisplayListPlayerSkia.cpp
@@ -320,10 +320,12 @@ static SkBitmap to_skia_bitmap(Gfx::Bitmap const& bitmap)
     SkBitmap sk_bitmap;
     sk_bitmap.setInfo(image_info);
 
-    if (!sk_bitmap.installPixels(image_info, (void*)bitmap.begin(), bitmap.width() * 4)) {
+    if (!sk_bitmap.installPixels(image_info, const_cast<Gfx::ARGB32*>(bitmap.begin()), bitmap.width() * 4)) {
         VERIFY_NOT_REACHED();
     }
 
+    sk_bitmap.setImmutable();
+
     return sk_bitmap;
 }