Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibGfx: Don't try to paint glyphs that aren't in a font #179

Merged

Conversation

awesomekling
Copy link
Member

Fixes #88

@AtkinsSJ
Copy link
Contributor

Should this try to draw the "missing character" symbol instead? Or is that already handled somewhere else.

@awesomekling
Copy link
Member Author

Should this try to draw the "missing character" symbol instead? Or is that already handled somewhere else.

If we wanted to draw the "missing character", we should have figured that out much earlier and asked to draw the missing character glyph :)

@awesomekling
Copy link
Member Author

If we didn't choose the missing character glyph earlier, we most likely think whatever we're drawing will fit into 0x0 space as well 😅

@AtkinsSJ
Copy link
Contributor

Yeah I'm just a little confused how we end up here without a valid glyph. It's fine as a "just in case" check, it's just odd that we're hitting it.

@awesomekling awesomekling merged commit fbc42e7 into LadybirdBrowser:master Jun 16, 2024
6 checks passed
@awesomekling awesomekling deleted the dont-paint-missing-glyph branch June 16, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ladybird is crashing on linux.org.ru
2 participants