LibWasm: Fix sign issues in SIMD cmp ops #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpfard
reviewed
Jul 12, 2024
Comment on lines
+293
to
+294
| SetSign<ElementType> lhs = result[i]; | ||
| SetSign<ElementType> rhs = other[i]; |
There was a problem hiding this comment.
🤔 why would the signs be different? we already set them through the vector type
There was a problem hiding this comment.
To be honest with you... I have no idea why. I think it could be a number of things related to NativeVectorType and how the compiler does inference around it. Or we need to be explicit because the compiled native SIMD instructions aren't taking sign into account the way we wrote it before.
This does make around 100 tests pass, though.
There was a problem hiding this comment.
Hmm
I'll take a look later today, and merge if there's no cleaner solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
simd_*_cmp.wastnow fully pass!