Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb: Implement the :has() pseudo-class #613

Merged
merged 1 commit into from
Jul 15, 2024
Merged

LibWeb: Implement the :has() pseudo-class #613

merged 1 commit into from
Jul 15, 2024

Conversation

dzfrias
Copy link
Contributor

@dzfrias dzfrias commented Jul 13, 2024

@dzfrias dzfrias requested a review from AtkinsSJ as a code owner July 13, 2024 17:44
@dzfrias dzfrias marked this pull request as draft July 13, 2024 20:50
@dzfrias dzfrias marked this pull request as ready for review July 13, 2024 21:33
AtkinsSJ
AtkinsSJ approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this!

I'm not totally in love with the name SelectorKind but I couldn't think of anything better. It'll do!

@AtkinsSJ AtkinsSJ merged commit f63a945 into LadybirdBrowser:master Jul 15, 2024
6 checks passed
@dzfrias dzfrias deleted the has-psuedo-class branch July 15, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtkinsSJ AtkinsSJ AtkinsSJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dzfrias @AtkinsSJ