AK: Add generic SIMD shuffle/reverse functions #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooops I think the AK ones are the wrong way around, |
|
lol oops |
|
|
I'm not sure if disabling -Wpsabi globally is safe to do in here; there are other libraries. |
(cherry picked from commit 8d6028d)
(cherry picked from commit 27c3867)
(cherry picked from commit 1b8fd5c)
This necessitates marking bit_cast as ALWAYS_INLINE since emitting it as a function call there will create an unnecessary potential SSE registers -> plain registers/memory round-trip.
Otherwise we'd hit a VERIFY in AK::SIMD::shuffle() when that operand contains an out-of-range value, the spec tests indicate that a swizzle with an out-of-range index should return 0. (cherry picked from commit cd454a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 1b8fd5c)
cc @Hendiadyoin1.