UI/Qt: Move New Tab button in tab bar #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladybird/Qt/BrowserWindow.h
Outdated
| @@ -212,6 +214,7 @@ public slots: | |||
| StringView m_webdriver_content_ipc_path; | |||
|
|
|||
| bool m_allow_popups { false }; | |||
| QToolBar* m_new_tab_button_toolbar { nullptr }; | |||
There was a problem hiding this comment.
A bit of an awkward place to put this, it is up to you, but maybe it could be closer m_zoom_menu like so?
QMenu* m_zoom_menu { nullptr };
QToolBar* m_new_tab_button_toolbar { nullptr };
QMenu* m_hamburger_menu { nullptr };Also, the button disappearing given too many tabs is a bit odd. Could the TabWidget width be limited so that it always leaves room for it? Otherwise pretty cool
|
I've not investigated why this happens, but the New Tab button isn't visible when the menu bar is shown (via View -> Show Menubar). |
lmutter
force-pushed
the
move-new-tab-button
branch
from
aaccba8
to
6155944
Compare
|
Fixed the sizing so that it always makes room for the button, also fixed its position when the new menu bar is enabled
|
|
Thanks! This resolves my comment. |
lmutter
force-pushed
the
move-new-tab-button
branch
from
6155944
to
d0934d8
Compare
ADKaster
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the tab bar's width to determine the location of the button. The button is hidden if the window is small enough
This is in reference to #252
QToolBar with a single action is used instead of just a QToolButton, there is an issue where the button is completely black when just using a button. If that is resolved, it could be used instead.