LibWeb: Add support for indexed setter of HTMLOptionsCollection #630
+58
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+79
to
+82
| // The spec doesn't seem to require this, but it's consistent with length handling and other browsers | ||
| if (index > 100'000) { | ||
| return {}; | ||
| } |
There was a problem hiding this comment.
Since we're adding a weird special case, let's make sure we test it as well :)
| return WebIDL::TypeMismatchError::create(realm(), "The value provided is not an HTMLOptionElement"_fly_string); | ||
| } | ||
|
|
||
| auto& option = dynamic_cast<HTMLOptionElement&>(unconverted_option.as_object()); |
There was a problem hiding this comment.
Should be okay to static_cast<HTMLOptionElement&> here as you have verified just above that it is indeed an option element.
subham8907
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.